From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3 15/16] net/avp: device start and stop
	operations
Date: Wed, 1 Mar 2017 16:37:29 -0800
Message-ID: <20170301163729.6b687ad9@xeon-e3>
References: <1488136143-116389-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-1-git-send-email-allain.legacy@windriver.com>
 <1488414008-162839-16-git-send-email-allain.legacy@windriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <ferruh.yigit@intel.com>, <ian.jolliffe@windriver.com>,
 <jerin.jacob@caviumnetworks.com>, <thomas.monjalon@6wind.com>,
 <dev@dpdk.org>
To: Allain Legacy <allain.legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id D4C5B2BB1
 for <dev@dpdk.org>; Thu,  2 Mar 2017 01:37:31 +0100 (CET)
Received: by mail-pf0-f179.google.com with SMTP id x66so16023558pfb.3
 for <dev@dpdk.org>; Wed, 01 Mar 2017 16:37:31 -0800 (PST)
In-Reply-To: <1488414008-162839-16-git-send-email-allain.legacy@windriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 1 Mar 2017 19:20:07 -0500
Allain Legacy <allain.legacy@windriver.com> wrote:

> +
> +static void
> +avp_dev_close(struct rte_eth_dev *eth_dev)
> +{
> +	struct avp_dev *avp = AVP_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
> +	int ret;
> +
> +	rte_spinlock_lock(&avp->lock);
> +	if (avp->flags & AVP_F_DETACHED) {
> +		PMD_DRV_LOG(ERR, "Operation not supported during VM live migration\n");
> +		goto unlock;
> +	}
> +
> +	/* remember current link state */
> +	avp->flags &= ~AVP_F_LINKUP;
> +	avp->flags &= ~AVP_F_CONFIGURED;
> +
> +	ret = avp_dev_disable_interrupts(eth_dev);
> +	if (ret < 0) {
> +		PMD_DRV_LOG(ERR, "Failed to disable interrupts\n");
> +		/* continue */
> +	}
> +
> +	/* update device state */
> +	ret = avp_dev_ctrl_shutdown(eth_dev);
> +	if (ret < 0) {
> +		PMD_DRV_LOG(ERR, "Device shutdown failed by host, ret=%d\n",
> +			    ret);
> +		goto unlock;
> +	}
> +
> +unlock:
> +	rte_spinlock_unlock(&avp->lock);
> +}

The second goto is unnecessary.