From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH] devtools: add long lines to the list of options Date: Thu, 2 Mar 2017 14:04:28 +0100 Message-ID: <20170302130428.GE1821@bidouze.vm.6wind.com> References: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> <20170301100851.60c3e46c@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: Allain Legacy , thomas.monjalon@6wind.com, dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 74199F8C0 for ; Thu, 2 Mar 2017 14:04:37 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n11so23578320wma.1 for ; Thu, 02 Mar 2017 05:04:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170301100851.60c3e46c@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 01, 2017 at 10:08:51AM -0800, Stephen Hemminger wrote: >On Wed, 1 Mar 2017 12:44:19 -0500 >Allain Legacy wrote: > >> The checkpatch.pl tool is flagging warnings on long debug log strings. >> Since splitting these strings makes it difficult to search for logs it is >> preferred to allow these as exceptions to the long line rule. The addition >> of the LONG_LINE_STRINGS to the list of exceptions will allow lines that >> end with a string to exceed the maximum line length, but lines that end >> with variables or other constructs will still be flagged as errors. Also, >> lines that make use of PRIx64 with string concatenation will still be >> flagged if the beginning of the last string fragment begins after the 80 >> character threshold. >> >> Signed-off-by: Allain Legacy >> --- >> devtools/checkpatches.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >> index 78e155e..26ff419 100755 >> --- a/devtools/checkpatches.sh >> +++ b/devtools/checkpatches.sh >> @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ >> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ >> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ >> SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ >> -NEW_TYPEDEFS,COMPARISON_TO_NULL" >> +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING" >> >> print_usage () { >> cat <<- END_OF_HELP > >Maybe it is time to have our own DPDK version of checkpatch which knows about >DPDK API's like logging functions? Additionally, accepting the format strings PRIu8 and consort would be nice, as they are currently flagged as CamelCase. Same as some EAL functions (like eal_parse_pci_DomBDF and eal_parse_pci_BDF), but renaming those could be a better solution. -- Gaëtan Rivet 6WIND