From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [v3 2/3] LPM config file read option.
Date: Mon, 6 Mar 2017 08:45:13 -0800
Message-ID: <20170306084513.5d3cf820@xeon-e3>
References: <1488660259-6228-1-git-send-email-rkerur@gmail.com>
 <1488660259-6228-3-git-send-email-rkerur@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com
To: Ravi Kerur <rkerur@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 08466F97D
 for <dev@dpdk.org>; Mon,  6 Mar 2017 17:45:21 +0100 (CET)
Received: by mail-pf0-f171.google.com with SMTP id j5so62724609pfb.2
 for <dev@dpdk.org>; Mon, 06 Mar 2017 08:45:20 -0800 (PST)
In-Reply-To: <1488660259-6228-3-git-send-email-rkerur@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat,  4 Mar 2017 12:44:18 -0800
Ravi Kerur <rkerur@gmail.com> wrote:

> +#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {            \
> +	unsigned long val;                                      \
> +	char *end;                                              \
> +	errno = 0;                                              \
> +	val = strtoul((in), &end, (base));                      \
> +	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
> +		return -EINVAL;                               \
> +	(fd) = (typeof(fd))val;                                 \
> +	(in) = end + 1;                                         \
> +} while (0)
> +

Marcos are source of bugs,  please write as function.