From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v11 5/7] mbuf: add a timestamp to the mbuf
 for latencystats
Date: Thu, 9 Mar 2017 11:02:26 -0800
Message-ID: <20170309110226.2ce09891@xeon-e3>
References: <1489076734-31474-1-git-send-email-remy.horton@intel.com>
 <1489076734-31474-6-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>, Thomas
 Monjalon <thomas.monjalon@6wind.com>, Reshma Pattan
 <reshma.pattan@intel.com>
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f44.google.com (mail-pg0-f44.google.com [74.125.83.44])
 by dpdk.org (Postfix) with ESMTP id 6339C234
 for <dev@dpdk.org>; Thu,  9 Mar 2017 20:02:30 +0100 (CET)
Received: by mail-pg0-f44.google.com with SMTP id g2so12158434pge.3
 for <dev@dpdk.org>; Thu, 09 Mar 2017 11:02:30 -0800 (PST)
In-Reply-To: <1489076734-31474-6-git-send-email-remy.horton@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  9 Mar 2017 16:25:32 +0000
Remy Horton <remy.horton@intel.com> wrote:

> From: Harry van Haaren <harry.van.haaren@intel.com>
> 
> This commit adds a uint64_t to the mbuf struct,
> allowing collection of latency and jitter statistics
> by measuring packet I/O timestamps. This change is
> required by the latencystats library.
> 
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index ce57d47..e0dad6e 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -514,6 +514,9 @@ struct rte_mbuf {
>  
>  	/** Timesync flags for use with IEEE1588. */
>  	uint16_t timesync;
> +
> +	/** Timestamp for measuring latency. */
> +	uint64_t timestamp;
>  } __rte_cache_aligned;
>  
>  /**

This creates a hole in the mbuf structure, and won't apply to current
version of mbuf that has priv_size.