From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/1] net/mlx4: add port parameter
Date: Fri, 10 Mar 2017 08:34:59 -0800
Message-ID: <20170310083459.6c1aeac7@xeon-e3>
References: <f49bbc965816575b851b22ba3cbcd657a847d9b2.1488550887.git.gaetan.rivet@6wind.com>
 <70A7408C6E1BFB41B192A929744D8523968EC82E@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>, Nelio Laranjeiro
 <nelio.laranjeiro@6wind.com>
To: "Legacy, Allain" <Allain.Legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com
 [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 246462C01
 for <dev@dpdk.org>; Fri, 10 Mar 2017 17:35:02 +0100 (CET)
Received: by mail-pf0-f180.google.com with SMTP id j5so43683241pfb.2
 for <dev@dpdk.org>; Fri, 10 Mar 2017 08:35:02 -0800 (PST)
In-Reply-To: <70A7408C6E1BFB41B192A929744D8523968EC82E@ALA-MBC.corp.ad.wrs.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 10 Mar 2017 16:24:32 +0000
"Legacy, Allain" <Allain.Legacy@windriver.com> wrote:

> The robustness of the strtoul() could be improved with something like the=
 following to catch non-integer characters following the port number.=20
>=20
>     char *end =3D NULL;
>     tmp =3D strtoull(val, &end, 0);
>     if ((val[0] =3D=3D '\0') || (end =3D=3D NULL) || (*end !=3D '\0') || =
(errno !=3D 0))

Extra () no necessary here.
Also errno is not set unless the return value is ULLONG_MAX. It will be last
value.

Something like:
	tmp =3D strtoull(val, &end, 0);
	if (!*val || !*end || (tmp =3D=3D ULLONG_MAX && errno))
...

       If  endptr  is  not  NULL,  strtoul()  stores  the address of the fi=
rst
       invalid character in *endptr.  If there were no  digits  at  all,  s=
tr=E2=80=90
       toul()  stores  the  original value of nptr in *endptr (and returns =
0).
       In particular, if *nptr is not '\0' but **endptr is '\0' on return, =
the
       entire string is valid.
...

RETURN VALUE
       The strtoul() function returns either the result of the conversion  =
or,
       if  there  was  a leading minus sign, the negation of the result of =
the
       conversion represented as an unsigned value, unless the original  (n=
on=E2=80=90
       negated)  value  would  overflow; in the latter case, strtoul() retu=
rns
       ULONG_MAX and sets errno to ERANGE.  Precisely the same holds for  s=
tr=E2=80=90
       toull() (with ULLONG_MAX instead of ULONG_MAX).