From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/8] eal: support dynamic log types
Date: Fri, 17 Mar 2017 09:17:23 -0700
Message-ID: <20170317091723.38cfc7dd@xeon-e3>
References: <1486387756-16865-1-git-send-email-olivier.matz@6wind.com>
 <1489765882-30497-1-git-send-email-olivier.matz@6wind.com>
 <1489765882-30497-2-git-send-email-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, david.marchand@6wind.com,
 bruce.richardson@intel.com, keith.wiles@intel.com
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41])
 by dpdk.org (Postfix) with ESMTP id B0222CFA8
 for <dev@dpdk.org>; Fri, 17 Mar 2017 17:17:31 +0100 (CET)
Received: by mail-pg0-f41.google.com with SMTP id g2so44577812pge.3
 for <dev@dpdk.org>; Fri, 17 Mar 2017 09:17:31 -0700 (PDT)
In-Reply-To: <1489765882-30497-2-git-send-email-olivier.matz@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 17 Mar 2017 16:51:15 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> +static int
> +__rte_log_register(const char *name, int id)
> +{
> +	char *dup_name = NULL;
> +
> +	dup_name = strdup(name);

Useless initialization!

Many people were taught to always initialize variables. But that was before
compilers were smart enough to catch those errors.