From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] mk: optimize directory dependencies
Date: Mon, 20 Mar 2017 09:31:53 +0100
Message-ID: <20170320093153.2b6f6d99@platinum>
References: <1485191953-2613-1-git-send-email-olivier.matz@6wind.com>
 <1489770822-27539-1-git-send-email-olivier.matz@6wind.com>
 <CA+4wmqyu5Q2=KwBYXG-bHcBwTjRHEvj0YVZst5jnHwLGUnYqrQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>, dev@dpdk.org, keith.wiles@intel.com,
 jerin.jacob@caviumnetworks.com
To: Robin Jarry <robin.jarry@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com
 [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 1E70211DE
 for <dev@dpdk.org>; Mon, 20 Mar 2017 09:31:56 +0100 (CET)
Received: by mail-wr0-f180.google.com with SMTP id g10so86932793wrg.2
 for <dev@dpdk.org>; Mon, 20 Mar 2017 01:31:56 -0700 (PDT)
In-Reply-To: <CA+4wmqyu5Q2=KwBYXG-bHcBwTjRHEvj0YVZst5jnHwLGUnYqrQ@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Robin,

On Fri, 17 Mar 2017 18:47:20 +0100, Robin Jarry <robin.jarry@6wind.com> wro=
te:
> Hi Olivier,
>=20
> Thanks again for this. I only have minor cosmetic remarks:
>=20
> Le 17 mars 2017 18:13, "Olivier Matz" <olivier.matz@6wind.com> a =C3=A9cr=
it:
> > diff --git a/app/pdump/Makefile b/app/pdump/Makefile
> > index 536198f..8ec6bd6 100644
> > --- a/app/pdump/Makefile
> > +++ b/app/pdump/Makefile
> > @@ -42,7 +42,6 @@ CFLAGS +=3D $(WERROR_FLAGS)
> >  SRCS-y :=3D main.c
> >
> >  # this application needs libraries first
> > -DEPDIRS-y +=3D lib
> >
> >  include $(RTE_SDK)/mk/rte.app.mk =20
>=20
> Maybe remove the comment line too?
>
> > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> > index eec1ed0..3be1ae8 100644
> > --- a/app/test-pmd/Makefile
> > +++ b/app/test-pmd/Makefile
> > @@ -82,7 +82,6 @@ endif
> >  CFLAGS_cmdline.o :=3D -D_GNU_SOURCE
> >
> >  # this application needs libraries first
> > -DEPDIRS-y +=3D lib drivers
> >
> >  include $(RTE_SDK)/mk/rte.app.mk =20
>=20
> Same here. There may be others.

Thanks, I'll check for other occurrences.


> > --- a/mk/rte.subdir.mk
> > +++ b/mk/rte.subdir.mk
> > @@ -59,8 +61,9 @@ build: _postbuild
> >  .PHONY: $(DIRS-y)
> >  $(DIRS-y):
> >         @[ -d $(CURDIR)/$@ ] || mkdir -p $(CURDIR)/$@
> > -       @echo "=3D=3D Build $S/$@"
> > +       @echo "=3D=3D Build $S/$@ " =20
>=20
> Why change this line ?

It's a typo, I'll remove it in v2.

Thanks for your review
Olivier