From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH 1/1] net/mlx4: add port parameter
Date: Mon, 20 Mar 2017 14:56:58 +0100
Message-ID: <20170320135658.GW3790@6wind.com>
References: <f49bbc965816575b851b22ba3cbcd657a847d9b2.1488550887.git.gaetan.rivet@6wind.com>
 <20170316110409.GO3790@6wind.com>
 <8dfd3eff-5326-5561-396a-11482ba3cc87@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 "Legacy, Allain" <Allain.Legacy@windriver.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com
 [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 373C519F5
 for <dev@dpdk.org>; Mon, 20 Mar 2017 14:57:08 +0100 (CET)
Received: by mail-wr0-f177.google.com with SMTP id g10so92978563wrg.2
 for <dev@dpdk.org>; Mon, 20 Mar 2017 06:57:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <8dfd3eff-5326-5561-396a-11482ba3cc87@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Mon, Mar 20, 2017 at 01:24:36PM +0000, Ferruh Yigit wrote:
> On 3/16/2017 11:04 AM, Adrien Mazarguil wrote:
> > On Fri, Mar 03, 2017 at 04:40:06PM +0100, Gaetan Rivet wrote:
> >> Most ConnectX-3 adapters expose two physical ports on a single PCI bus
> >> address.
> >>
> >> Add a new port parameter allowing the user to choose
> >> either or both physical ports to be used by the application.
> >>
> >> This parameter is used as follows:
> >>
> >> Selecting only the second port:
> >>    -w 00:00.0,port=1
> >>
> >> Selecting both ports:
> >>    -w 00:00.0,port=0,port=1
> >>
> >> If no parameter is given, the default behavior is unchanged: all ports
> >> are probed.
> >>
> >> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > 
> > I think this patch is good as is. Whatever value results from users
> > specifying random characters as argument to the port parameter is their
> > problem, as long as the resulting value is verified to be within bounds,
> > it's fine.
> > 
> > I'm not saying that checking all possible failure modes of strtoul() is
> > useless, just that it seems overkill in this specific case. Using atoi()
> > without any error checking would have been perfectly fine as well.
> > 
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> Hi Adrien, Gaetan,
> 
> Are all comments addressed for this patch? It looks like discussion is
> going on?

I think it's over, no more comments will follow.

-- 
Adrien Mazarguil
6WIND