From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] net/ixgbevf: fix stats update after a PF
 reset
Date: Fri, 24 Mar 2017 15:11:48 +0100
Message-ID: <20170324151148.5c3d9f9d@platinum>
References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com>
 <20170206145858.41447b6e@platinum>
 <49759EB36A64CF4892C1AFEC9231E8D63A3598F0@PGSMSX106.gar.corp.intel.com>
 <20170216174922.720f83b9@platinum>
 <20170314104640.32b06adb@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin" <helin.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Guo Fengtian
 <fengtian.guo@6wind.com>
To: "Dai, Wei" <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id E3A1ED49E
 for <dev@dpdk.org>; Fri, 24 Mar 2017 15:11:50 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id n11so14079621wma.1
 for <dev@dpdk.org>; Fri, 24 Mar 2017 07:11:50 -0700 (PDT)
In-Reply-To: <20170314104640.32b06adb@platinum>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

(remove stable@dpdk.org)

On Tue, 14 Mar 2017 10:46:40 +0100, Olivier Matz <olivier.matz@6wind.com> wrote:
> Hi Wei,
> 
> On Thu, 16 Feb 2017 17:49:22 +0100, Olivier Matz <olivier.matz@6wind.com> wrote:
> > Hi Wei,
> > 
> > On Thu, 9 Feb 2017 14:50:05 +0000, "Dai, Wei" <wei.dai@intel.com> wrote:  
> > > > -----Original Message-----
> > > > From: Dai, Wei
> > > > Sent: Thursday, February 9, 2017 10:38 PM
> > > > To: 'Olivier Matz' <olivier.matz@6wind.com>; dev@dpdk.org; Zhang,
> > > > Helin <helin.zhang@intel.com>; Ananyev, Konstantin
> > > > <konstantin.ananyev@intel.com>
> > > > Cc: Guo Fengtian <fengtian.guo@6wind.com>; stable@dpdk.org
> > > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after
> > > > a PF reset
> > > > 
> > > > The stats register can rewind to zero when the port is running for
> > > > a long period. So I am afraid that this check is not always correct.
> > > > Why not introduce a variable to directly indicate whether the
> > > > resulted stats should be updated or not.    
> > >
> > > Another way is to clear
> > > hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same
> > > time PF is set down.
> > >     
> > 
> > Can we know easily in VF if the PF was set down?  
> 
> Any guideline for this? Or is it something we cannot fix?
> 

Is any maintainer available to help to fix that?

Unfortunately I don't have enough knowledge on this driver to do the fix
by myself. It would be helpful to have some guidelines by a maintainer so
I can understand what is the proper way to fix the issue.

Thanks,
Olivier