From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH 0/2] lib: add TCP IPv4 GRO support
Date: Fri, 24 Mar 2017 15:59:06 +0100
Message-ID: <20170324155906.4b88a38d@platinum>
References: <1B893F1B-4DA8-4F88-9583-8C0BAA570832@intel.com>
 <20170323021502.GA114662@localhost.localdomain>
 <C830A6FC-F440-4E68-AB4E-2FD502722E3F@intel.com>
 <20170323062433.GA120139@localhost.localdomain>
 <59AF69C657FD0841A61C55336867B5B066729E3F@IRSMSX103.ger.corp.intel.com>
 <20170323102135.GA124301@localhost.localdomain>
 <2601191342CEEE43887BDE71AB9772583FAD410A@IRSMSX109.ger.corp.intel.com>
 <20170324022310.GA129105@localhost.localdomain>
 <32FED22E-7116-4B6A-894E-C81CBF7B4BBE@intel.com>
 <20170324072230.GU18844@yliu-dev.sh.intel.com>
 <20170324080633.GA2865@localhost.localdomain>
 <2601191342CEEE43887BDE71AB9772583FAD80A6@IRSMSX109.ger.corp.intel.com>
 <0C56AF3E-C8AB-4903-AD34-F39C6D74C889@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Hu, Jiayu"
 <jiayu.hu@intel.com>, Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, Stephen Hemminger
 <stephen@networkplumber.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Liang, Cunming" <cunming.liang@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 5A0C7D380
 for <dev@dpdk.org>; Fri, 24 Mar 2017 15:59:09 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id n11so15185316wma.1
 for <dev@dpdk.org>; Fri, 24 Mar 2017 07:59:09 -0700 (PDT)
In-Reply-To: <0C56AF3E-C8AB-4903-AD34-F39C6D74C889@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 24 Mar 2017 14:37:04 +0000, "Wiles, Keith" <keith.wiles@intel.com> wrote:
> > On Mar 24, 2017, at 6:43 AM, Ananyev, Konstantin <konstantin.ananyev@intel.com> wrote:
> > 
> > 
> >   

[...]

> > Yep, that's what my take from the beginning:
> > Let's develop a librte_gro first and make it successful, then we can think should
> > we (and how) put into ethdev layer.  
> 
> Let not create a gro library and put the code into librte_net as size is not a concern yet and it is the best place to put the code. As for ip_frag someone can move it into librte_net if someone writes the patch.

The size of a library _is_ an argument. Not the binary size in bytes, but
its API, because that's what the developper sees. Today, librte_net contains
protocol headers definitions and some network helpers, and the API surface
is already quite big (look at the number of lines of .h files).

I really like having a library name which matches its content.
The anwser to "what can I find in librte_gro?" is quite obvious.


Regards
Olivier