From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v1] mempool/dpaa2: add DPAA2 hardware
 offloaded mempool
Date: Fri, 24 Mar 2017 17:31:46 +0100
Message-ID: <20170324173146.477a5157@platinum>
References: <1489754838-1455-1-git-send-email-hemant.agrawal@nxp.com>
 <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com>
 <7d898278-9331-0c72-cabd-9318c6d65f1e@intel.com>
 <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org,
 thomas.monjalon@6wind.com, shreyansh.jain@nxp.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 6B7FE69A5
 for <dev@dpdk.org>; Fri, 24 Mar 2017 17:31:49 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id n11so6621914wma.0
 for <dev@dpdk.org>; Fri, 24 Mar 2017 09:31:49 -0700 (PDT)
In-Reply-To: <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Fri, 24 Mar 2017 15:59:50 +0000, Ferruh Yigit <ferruh.yigit@intel.com> w=
rote:
> On 3/24/2017 2:57 PM, Ferruh Yigit wrote:
> > On 3/17/2017 12:47 PM, Hemant Agrawal wrote: =20
> >> DPAA2 Hardware Mempool handlers allow enqueue/dequeue from NXP's
> >> QBMAN hardware block.
> >> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS is set to 'dpaa2', if the pool
> >> is enabled.
> >>
> >> This memory pool currently supports packet mbuf type blocks only.
> >>
> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> =20
> >=20
> > Applied to dpdk-next-net/master, thanks. =20
>=20
> Hi Olivier,
>=20
> I get this to next-net, since dpaa2 net driver depends this one.
>=20
> But were you planning any review on the code? Or is it good to go as it i=
s?

Yes, but I'm afraid I won't be able to do it today.

=46rom high level, I'm still a little puzzled by the amount of references
to mbuf in a mempool handler code, which should theorically handle any
kind of objects.

Is it planned to support other kind of objects?
Does this driver passes the mempool autotest?
Can the user be aware of these limitations?


Thanks,
Olivier