From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 03/14] ring: eliminate duplication of size
 and mask fields
Date: Mon, 27 Mar 2017 11:13:39 +0100
Message-ID: <20170327101338.GA18148@bricha3-MOBL3.ger.corp.intel.com>
References: <20170307113217.11077-1-bruce.richardson@intel.com>
 <20170324171008.29355-1-bruce.richardson@intel.com>
 <20170324171008.29355-4-bruce.richardson@intel.com>
 <2476675.J1ds0gYDs0@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 59B54FA72
 for <dev@dpdk.org>; Mon, 27 Mar 2017 12:13:43 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <2476675.J1ds0gYDs0@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote:
> 2017-03-24 17:09, Bruce Richardson:
> > The size and mask fields are duplicated in both the producer and
> > consumer data structures. Move them out of that into the top level
> > structure so they are not duplicated.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Sorry Bruce, I encounter this error:
> 
> fatal error: no member named 'size' in 'struct rte_ring_headtail'
>                 if (r->prod.size >= ring_size) {
>                     ~~~~~~~ ^
>
Hi Thomas,

again I need more information here. I've just revalidated these first
three patches doing 7 builds with each one (gcc, clang, debug, shared 
library, old ABI, default-machine and 32-bit), as well as compiling the
apps for gcc and clang, and I see no errors.

/Bruce