From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 03/14] ring: eliminate duplication of size
 and mask fields
Date: Mon, 27 Mar 2017 15:57:40 +0100
Message-ID: <20170327145740.GA14876@bricha3-MOBL3.ger.corp.intel.com>
References: <20170307113217.11077-1-bruce.richardson@intel.com>
 <2476675.J1ds0gYDs0@xps13>
 <20170327101549.GB18148@bricha3-MOBL3.ger.corp.intel.com>
 <3439297.P6JfIMhuDO@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id EA16AFB06
 for <dev@dpdk.org>; Mon, 27 Mar 2017 16:57:44 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <3439297.P6JfIMhuDO@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Mar 27, 2017 at 03:13:04PM +0200, Thomas Monjalon wrote:
> 2017-03-27 11:15, Bruce Richardson:
> > On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote:
> > > 2017-03-24 17:09, Bruce Richardson:
> > > > The size and mask fields are duplicated in both the producer and
> > > > consumer data structures. Move them out of that into the top level
> > > > structure so they are not duplicated.
> > > > 
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > > 
> > > Sorry Bruce, I encounter this error:
> > > 
> > > fatal error: no member named 'size' in 'struct rte_ring_headtail'
> > >                 if (r->prod.size >= ring_size) {
> > >                     ~~~~~~~ ^
> > > 
> > Ok, I think I've found it now using git grep. I assume this is in the
> > crypto code which is disabled by default, right?
> 
> Right, sorry for forgetting the context.

Submitted a new patch for the crypto drivers to fix this issue. The
previous patch I did to fix this as a pre-requisite didn't catch the
drivers that were disabled by default.

http://dpdk.org/dev/patchwork/patch/22445/

I've verified this now compiles with the aesni-mb crypto PMD enabled at
least. I'll see about enabling a few more crypto drivers on my system
just in case there are other things I missed in them for this set.

/Bruce