From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3 08/14] ring: allow enqueue fns to return
 free space value
Date: Tue, 28 Mar 2017 09:16:34 +0100
Message-ID: <20170328081634.GA20844@bricha3-MOBL3.ger.corp.intel.com>
References: <20170307113217.11077-1-bruce.richardson@intel.com>
 <20170324171008.29355-1-bruce.richardson@intel.com>
 <20170324171008.29355-9-bruce.richardson@intel.com>
 <1777203.ud4AFtxiB3@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id CF11E695D
 for <dev@dpdk.org>; Tue, 28 Mar 2017 10:16:38 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1777203.ud4AFtxiB3@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Mar 28, 2017 at 09:12:39AM +0200, Thomas Monjalon wrote:
> 2017-03-24 17:10, Bruce Richardson:
> > Add an extra parameter to the ring enqueue burst/bulk functions so that
> > those functions can optionally return the amount of free space in the
> > ring. This information can be used by applications in a number of ways,
> > for instance, with single-producer queues, it provides a max
> > enqueue size which is guaranteed to work. It can also be used to
> > implement watermark functionality in apps, replacing the older
> > functionality with a more flexible version, which enables apps to
> > implement multiple watermark thresholds, rather than just one.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> 
> There is a an error with this patch and crypto drivers:
> 
> 
> drivers/crypto/kasumi/rte_kasumi_pmd.c:362:32: fatal error:
> too few arguments to function call, expected 4, have 3
>                                 (void **)ops, processed_ops);
>                                                            ^
> rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here
> 
> 
> drivers/crypto/snow3g/rte_snow3g_pmd.c:366:31: fatal error:
> too few arguments to function call, expected 4, have 3
>                         (void **)ops, processed_ops);
>                                                    ^
> rte_ring.h:1018:1: note: 'rte_ring_enqueue_burst' declared here
> 
Yes, I'm still working through this patchset with crypto drivers enabled
myself. Patch 9 also has issues with some of the other drivers - though
I don't have this kasumi one enabled on my system myself. I'll need to
do a v4, hopefully today. Sorry for not flagging this sooner, I didn't
know you were going to try again to apply the set, so I thought I had
more time to report the results of testing with the crypto drivers.

/Bruce