From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2 1/1] pci: default to whitelist mode Date: Tue, 28 Mar 2017 13:20:00 +0100 Message-ID: <20170328122000.GA24328@bricha3-MOBL3.ger.corp.intel.com> References: <1490701917-17089-1-git-send-email-gaetan.rivet@6wind.com> <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Thomas Monjalon To: Gaetan Rivet Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 51725D208 for ; Tue, 28 Mar 2017 14:20:04 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1490702489-17950-1-git-send-email-gaetan.rivet@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 28, 2017 at 02:01:29PM +0200, Gaetan Rivet wrote: > Expects all devices to be explicitly defined before being probed. > > The blacklist mode can be prone to errors, coaxing users in capturing > devices that could be used for management or otherwise. > The whitelist mode offers users more control and highlight mistakes by > making them visible on the command line. > > This is more useful to have a clear idea of the state of the system used, > which is better in the context of standalone / headless applications. > > Using the -b option will revert to the original behavior. > > Signed-off-by: Gaetan Rivet > --- > v2: justify this default behavior evolution. > --- I don't have major objections to this patch, though it does make it mandatory to use port parameters where before it was not. The one suggestion I will make is that, if we take this approach, we should probably add a --wl-all (whitelist-all) flag to go back to having all ports automatically bound, if so desired. /Bruce