From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: bug in LPM handling (16.04+)
Date: Wed, 29 Mar 2017 15:41:18 +0100
Message-ID: <20170329144117.GA10824@bricha3-MOBL3.ger.corp.intel.com>
References: <20170329122534.GO2871@elxafv3bk32>
 <20170329123813.GP2871@elxafv3bk32>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: =?iso-8859-1?Q?L=E1szl=F3_Moln=E1r?= <laszlo.molnar@ericsson.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id EEEFA377E
 for <dev@dpdk.org>; Wed, 29 Mar 2017 16:41:21 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20170329123813.GP2871@elxafv3bk32>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Mar 29, 2017 at 02:38:13PM +0200, László Molnár wrote:
> --- rte_lpm.c~3	2017-03-29 12:19:06.146933973 +0200
> +++ rte_lpm.c	2017-03-29 12:19:06.000000000 +0200
> @@ -1034,7 +1034,7 @@
>  		 */
> 
>  		struct rte_lpm_tbl_entry new_tbl24_entry = {
> -			.group_idx = (uint8_t)tbl8_group_index,
> +			.group_idx = tbl8_group_index,
>  			.valid = VALID,
>  			.valid_group = 1,
>  			.depth = 0,
> @@ -1080,7 +1080,7 @@
>  		 */
> 
>  		struct rte_lpm_tbl_entry new_tbl24_entry = {
> -				.group_idx = (uint8_t)tbl8_group_index,
> +				.group_idx = tbl8_group_index,
>  				.valid = VALID,
>  				.valid_group = 1,
>  				.depth = 0,
> 

Hi,

this fix looks reasonable. Can you perhaps resend as a proper patch with
signoff, as described in contributors guide doc? See: 
http://dpdk.org/doc/guides/contributing/patches.html#make-your-changes

Thanks,
/Bruce