From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] net/ixgbevf: fix stats update after a PF reset Date: Thu, 30 Mar 2017 13:58:53 +0200 Message-ID: <20170330135853.3ff18757@platinum> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170314104640.32b06adb@platinum> <20170324151148.5c3d9f9d@platinum> <1981763.1ss0qQn5ig@xps13> <49759EB36A64CF4892C1AFEC9231E8D650A23126@PGSMSX101.gar.corp.intel.com> <20170329120808.0907926a@platinum> <49759EB36A64CF4892C1AFEC9231E8D650A239EC@PGSMSX101.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , "Zhang, Helin" , "Ananyev, Konstantin" , "dev@dpdk.org" , Guo Fengtian , "Yigit, Ferruh" To: "Dai, Wei" Return-path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id AB50A10F62 for ; Thu, 30 Mar 2017 13:58:56 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id w43so57414884wrb.0 for ; Thu, 30 Mar 2017 04:58:56 -0700 (PDT) In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A239EC@PGSMSX101.gar.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Wei, On Thu, 30 Mar 2017 10:46:45 +0000, "Dai, Wei" wrote: > HI, Olivier > > > > > Hi Wei, > > > > On Wed, 29 Mar 2017 09:22:55 +0000, "Dai, Wei" wrote: > > > First of all, I don't agree the method in this patch because the > > > register can also rewind to 0 in normal mode except reset/PF down. > > > > > > In the function void ixgbe_down(struct ixgbe_adapter *adapter) of > > > ixgbe_main.c in the ixgbe kernel PF driver (version 5.0.4), the PF in kernel > > driver will ping all the active vfs to let them know PF is going down by mailbox > > messages. > > > > > > On other side, ixgbe VF in DPDK PMD will handle the ping mailbox > > > message in ixgbevf_dev_interrupt_handler( ) which is registered interrupt > > routine. > > > And ixgbevf_dev_interrupt_handler( ) will call ixgbevf_mbx_process( ) to > > process mailbox message from PF. > > > > > > So it is in ixgbevf_mbx_process( ) where the SW stats registers of VF can be > > fixed. > > > There is more than one line to send ping message to VF in kernel PF drvier > > codes. > > > > Thank you for the explanation. > > > > Just to be sure I correctly understand: > > 1- the ping message is properly sent by ixgbe pf linux driver > Yes, I think so. > > > 2- the ping message is not yet sent by ixgbe pf dpdk driver > I have not find any codes in DPDK PF to send them. > > > 3- the ping message is properly received by ixgbe vf dpdk driver, but > > it is not used yet to stop wrong stats accumulation > Yes, need register some callback function on to handle it. > > > > > > I am studying it to make it clear how to identify the ping message due to PF > > down. > > > > Are you saying that you are currently working on a fix for 2 and 3 (that would be > > great!) or are you expecting that I work on it? In any case, I can help, at least > > to test the patches. > > I am working on it now. Need check both ixgbe kernel driver and DPDK driver and also > need look up some pages in datasheet including 82599, X540 and X550. > So it is not an easy task. > By the way, not only statistics function but also other configurations should be > restored. > > Anyway, I always appreciate your help. Of course, you can help me test my upcoming patches. Great, thank you. Please CC me when you send the patches, I'll test them. Regards, Olivier