From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 3/4] devtools: remove special case build
 for perf thread example
Date: Fri, 31 Mar 2017 10:15:10 +0100
Message-ID: <20170331091509.GC7668@bricha3-MOBL3.ger.corp.intel.com>
References: <20170329140419.27149-1-bruce.richardson@intel.com>
 <1632639.Ait0E45soG@xps13>
 <20170330153003.GA14552@bricha3-MOBL3.ger.corp.intel.com>
 <1775524.8P82GFJXp7@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 9D07CFE5
 for <dev@dpdk.org>; Fri, 31 Mar 2017 11:15:14 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1775524.8P82GFJXp7@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote:
> 2017-03-30 16:30, Bruce Richardson:
> > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > > 2017-03-29 17:38, Bruce Richardson:
> > > > Since performance-thread example app is now built as part of make examples
> > > > we don't need a special case line for it in testbuild.sh script
> > > [...]
> > > > --- a/devtools/test-build.sh
> > > > +++ b/devtools/test-build.sh
> > > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > >  		O=$(readlink -m $dir/examples)
> > > >  	! echo $target | grep -q '^x86_64' || \
> > > > -	make -j$J -sC examples/performance-thread \
> > > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > -		O=$(readlink -m $dir/examples/performance-thread)
> > > 
> > > You are missing the x86_64 check.
> > 
> > That's in the makefile in the first patch
> 
> Sorry, I mean you should remove the above check:
> 	! echo $target | grep -q '^x86_64' || \
> 
Oops, yes, you are right. Do you need a V3 of this set, or can you just
fix it up as you like it on apply?

/Bruce