From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 2/2] net/i40e: remove option to disable offload flags Date: Mon, 3 Apr 2017 15:51:39 +0100 Message-ID: <20170403145138.GA676@bricha3-MOBL3.ger.corp.intel.com> References: <20170403143944.17719-1-bruce.richardson@intel.com> <20170403143944.17719-3-bruce.richardson@intel.com> <84c55d48-513b-f9c2-c9e2-8e2cc920f989@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com, jianbo.liu@linaro.org To: Ferruh Yigit Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B69DC282 for ; Mon, 3 Apr 2017 16:51:43 +0200 (CEST) Content-Disposition: inline In-Reply-To: <84c55d48-513b-f9c2-c9e2-8e2cc920f989@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 03, 2017 at 03:45:46PM +0100, Ferruh Yigit wrote: > On 4/3/2017 3:39 PM, Bruce Richardson wrote: > > Having packets received without any offload flags given in the mbuf is not > > very useful, and performance tests with testpmd indicates little to no > > benefit is got with the current code by turning off the flags. This makes > > the build-time option pointless, so we can remove it. > > > > Signed-off-by: Bruce Richardson > > --- > > config/common_base | 1 - > > doc/guides/nics/i40e.rst | 5 ----- > > drivers/net/i40e/i40e_rxtx_vec_common.h | 8 -------- > > drivers/net/i40e/i40e_rxtx_vec_neon.c | 11 ----------- > > drivers/net/i40e/i40e_rxtx_vec_sse.c | 11 ----------- > > Should this patch also update powerpc vector PMD (i40e_rxtx_vec_altivec.c) ? > Yes, good catch. I based this work off the main tree rather than next-net as I was looking at the mbuf changes primarily. Once we get either next-net or the mbuf patches merged in, I'll do a V2 with all updates included. /Bruce