From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qi Zhang Subject: [PATCH v4 0/2] clean up interrupt handle Date: Wed, 5 Apr 2017 05:21:23 +0800 Message-ID: <20170404212125.32114-1-qi.z.zhang@intel.com> References: <20170331020913.19004-1-qi.z.zhang@intel.com> Cc: dev@dpdk.org, Qi Zhang To: thomas.monjalon@6wind.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 68C36326C for ; Tue, 4 Apr 2017 15:27:19 +0200 (CEST) In-Reply-To: <20170331020913.19004-1-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It seems its not necessary to register an intr_handle for interrupt callback function. "void* cb_arg" shows enough when be used to pass the object that contain the information be required to handle the interrupt event( A typical way which is implemented by almost all driver is by passing a rte_ethdev instance). The patch change the prototype of rte_intr_callback_fn by removing the uncessary intr_handle paramter. v4: - Update mlx5 driver which is missed in v1, v2, v3. - Add back patch 1 of v2 to make this complete though it already be applied. - Remove patch 3 which is not necessary with latest master. v3: - Update bnx2x driver which is missed in v1,v2 v2: - Seperate patch 1 in v1 into 2 patches. - Correct some commit log. Qi Zhang (2): vfio: keep interrupt source read only eal: clean up interrupt handle drivers/net/bnx2x/bnx2x_ethdev.c | 5 ++-- drivers/net/bnxt/bnxt_irq.c | 3 +- drivers/net/e1000/em_ethdev.c | 8 ++---- drivers/net/e1000/igb_ethdev.c | 15 ++++------ drivers/net/enic/enic_main.c | 3 +- drivers/net/fm10k/fm10k_ethdev.c | 12 +++----- drivers/net/i40e/i40e_ethdev.c | 8 ++---- drivers/net/i40e/i40e_ethdev_vf.c | 5 ++-- drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++----- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_ethdev.c | 3 +- drivers/net/nfp/nfp_net.c | 6 ++-- drivers/net/qede/qede_ethdev.c | 4 +-- drivers/net/sfc/sfc_intr.c | 10 ++++--- drivers/net/virtio/virtio_ethdev.c | 5 ++-- lib/librte_eal/common/include/rte_interrupts.h | 3 +- lib/librte_eal/linuxapp/eal/eal_alarm.c | 5 ++-- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 39 ++++---------------------- 18 files changed, 50 insertions(+), 100 deletions(-) -- 2.7.4