From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH 0/2] net/virtio: support to turn on/off the
	traffic flow
Date: Thu, 6 Apr 2017 11:59:53 +0800
Message-ID: <20170406035953.GM18844@yliu-dev.sh.intel.com>
References: <1490960419-16779-1-git-send-email-zhiyong.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, maxime.coquelin@redhat.com
To: Zhiyong Yang <zhiyong.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 172294CC5
 for <dev@dpdk.org>; Thu,  6 Apr 2017 06:02:30 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1490960419-16779-1-git-send-email-zhiyong.yang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 31, 2017 at 07:40:17PM +0800, Zhiyong Yang wrote:
> Current dpdk code virtio_dev_stop only disables interrupt and marks link down,
> When it is invoked, tx/rx traffic flows still work. This is a strange behavior.
> The patchset supports the switch of flow by calling virtio_dev_start/stop.
> 
> The implementation refers to vhost pmd.

That's a difference story. Vhost pmd uses 2 vars to track the
status, whereas you are using only one here. So why not
setting/clearing "started" at dev_start/stop, respectively?
Then we can check "started" at Rx/Tx functions.

BTW, why does it have to be atomic?

	--yliu
> 
> Zhiyong Yang (2):
>   net/virtio: add data elements to turn on/off traffic flow
>   net/virtio: support to turn on/off the traffic flow
> 
>  drivers/net/virtio/virtio_ethdev.c           | 37 +++++++++++++++++++++++++++-
>  drivers/net/virtio/virtio_pci.h              |  1 +
>  drivers/net/virtio/virtio_rxtx.c             | 12 +++++++++
>  drivers/net/virtio/virtio_rxtx.h             |  6 +++++
>  drivers/net/virtio/virtio_rxtx_simple.c      |  4 +++
>  drivers/net/virtio/virtio_rxtx_simple_neon.c |  5 +++-
>  drivers/net/virtio/virtio_rxtx_simple_sse.c  |  5 +++-
>  drivers/net/virtio/virtio_user_ethdev.c      |  1 +
>  8 files changed, 68 insertions(+), 3 deletions(-)
> 
> -- 
> 2.7.4