From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v3] ether: use a default for max Rx frame
 size in configure()
Date: Fri, 7 Apr 2017 13:29:57 +0100
Message-ID: <20170407122956.GA26192@bricha3-MOBL3.ger.corp.intel.com>
References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com>
 <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com>
 <7103767.xpENpphzvJ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>, dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 3E7D22B9B
 for <dev@dpdk.org>; Fri,  7 Apr 2017 14:30:01 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <7103767.xpENpphzvJ@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 07, 2017 at 02:15:47PM +0200, Thomas Monjalon wrote:
> 2017-04-07 13:02, Andriy Berestovskyy:
> > At the moment rte_eth_dev_configure() behaves inconsistent:
> >  - for normal frames: zero max_rx_pkt_len uses a default
> >  - for jumbo frames: zero max_rx_pkt_len gives an error
> > 
> > This patch fixes this inconsistency by using a default value
> > if max_rx_pkt_len is zero both for normal and jumbo frames.
> > 
> > Signed-off-by: Andriy Berestovskyy <Andriy.Berestovskyy@caviumnetworks.com>
> > ---
> > 
> > Notes:
> >     v3 changes:
> >      - use a default only if max_rx_pkt_len is zero
> 
> Looks good.
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> It is a small API change but it is fixing an inconsistency,
> so I think it can be integrated in 17.05-rc2 as is.
> Any different opinion?

Is this entirely hidden from drivers? As I said previously, I believe
NICs using ixgbe/i40e etc. only use the frame size value when the jumbo
frame flag is set. That may lead to further inconsistent behaviour unless
all NICs are set up to behave as expected too.

/Bruce