From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: [PATCH] net/ixgbe: fix duplicated check Date: Tue, 11 Apr 2017 16:20:34 +0100 Message-ID: <20170411152034.23784-1-ferruh.yigit@intel.com> Cc: dev@dpdk.org, Ferruh Yigit , Wenzhuo Lu , wei.zhao1@intel.com To: Helin Zhang ; Konstantin Ananyev Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 86664567F for ; Tue, 11 Apr 2017 17:20:39 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Same check duplicated, updated check according what commend states. Coverity issue: 1407507 Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Ferruh Yigit --- drivers/net/ixgbe/ixgbe_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index e2ba9c2..803d6f8 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr, index++; NEXT_ITEM_OF_PATTERN(item, pattern, index); if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && - (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) { + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, -- 2.9.3