From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] net/virtio: fix queue notify
Date: Thu, 13 Apr 2017 09:39:24 +0800
Message-ID: <20170413013924.GC7333@yliu-dev.sh.intel.com>
References: <1491907468-68207-1-git-send-email-xiao.w.wang@intel.com>
 <20170412143925.0916e609@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Xiao Wang <xiao.w.wang@intel.com>, dev@dpdk.org, stable@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <20170412143925.0916e609@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Apr 12, 2017 at 02:39:25PM -0700, Stephen Hemminger wrote:
> On Tue, 11 Apr 2017 03:44:28 -0700
> Xiao Wang <xiao.w.wang@intel.com> wrote:
> 
> > According to spec, we should write virtqueue index into the notify
> > address, rather than 1. Besides, some HW backend may rely on the data
> > written to identify which queue need to serve.
> > 
> > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> >  drivers/net/virtio/virtio_pci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
> > index ce9a9d3..b767c03 100644
> > --- a/drivers/net/virtio/virtio_pci.c
> > +++ b/drivers/net/virtio/virtio_pci.c
> > @@ -504,7 +504,7 @@
> >  static void
> >  modern_notify_queue(struct virtio_hw *hw __rte_unused, struct virtqueue *vq)
> >  {
> > -	rte_write16(1, vq->notify_addr);
> > +	rte_write16(vq->vq_queue_index, vq->notify_addr);
> >  }
> 
> 
> Yes, this looks correct. It is what Linux and FreeBSD drivers do.
> 
> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-virtio.

Thanks.

	--yliu