From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH] ethdev: fix compilation issue with strict flags Date: Thu, 13 Apr 2017 10:29:57 +0200 Message-ID: <20170413082957.GC13028@bidouze.vm.6wind.com> References: <20170413052927.82842-1-shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: thomas.monjalon@6wind.com, dev@dpdk.org To: Shahaf Shuler Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 5EC5A5942 for ; Thu, 13 Apr 2017 10:30:06 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id w64so105947054wma.0 for ; Thu, 13 Apr 2017 01:30:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170413052927.82842-1-shahafs@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes, with the __rte_cache_aligned, the :8 should be useless anyway. On Thu, Apr 13, 2017 at 08:29:27AM +0300, Shahaf Shuler wrote: >Compilation error seen while compiling mlx5 in debug mode >under RHEL 7.3: > >rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension > [-Werror=pedantic] > >Address it by removing the unnecessary bit-field width limitation. > >Fixes: d52268a8b24b ("ethdev: expose device states") > >Signed-off-by: Shahaf Shuler Acked-by: Gaetan Rivet >--- > lib/librte_ether/rte_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >index d07253874..2d1bc12aa 100644 >--- a/lib/librte_ether/rte_ethdev.h >+++ b/lib/librte_ether/rte_ethdev.h >@@ -1667,7 +1667,7 @@ struct rte_eth_dev { > * received packets before passing them to the driver for transmission. > */ > struct rte_eth_rxtx_callback *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT]; >- enum rte_eth_dev_state state:8; /**< Flag indicating the port state */ >+ enum rte_eth_dev_state state; /**< Flag indicating the port state */ > } __rte_cache_aligned; > > struct rte_eth_dev_sriov { >-- >2.12.0 > -- Gaëtan Rivet 6WIND