dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com
Subject: Re: [PATCH v2] net/virtio-user: fix cannot get initialized
Date: Fri, 14 Apr 2017 12:24:23 +0800	[thread overview]
Message-ID: <20170414042423.GI7333@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1492078287-138040-1-git-send-email-jianfeng.tan@intel.com>

On Thu, Apr 13, 2017 at 10:11:27AM +0000, Jianfeng Tan wrote:
> The feature negotiation in virtio-user is proven to be broken,
> which results in device initialization failure.
> 
> Originally, we get features from vhost backend, and remove those
> that are not supported. But when new feature is added, for example,
> VIRTIO_NET_F_MTU, we fail to remove this new feature. Then, this
> new feature will be negotiated, as both frontend and backend claim
> to support this feature.
> 
> To fix it, we add a macro to record supported featues, as a filter
> to remove newly added features.

Yes, this is much better! You now don't have to worry that virtio-user
will be broken every time we add a new feature.

Applied to dpdk-next-virtio, with the title changed to "fix feature
negotitation".

Thanks.

	--yliu

  reply	other threads:[~2017-04-14  4:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07  7:57 [PATCH] net/virtio-user: fix cannot get initialized Jianfeng Tan
2017-04-13  1:58 ` Yuanhan Liu
2017-04-13  2:18   ` Tan, Jianfeng
2017-04-13  2:21     ` Yuanhan Liu
2017-04-13  7:37       ` Tan, Jianfeng
2017-04-13  2:36     ` Yuanhan Liu
2017-04-13  7:39       ` Tan, Jianfeng
2017-04-13 10:11 ` [PATCH v2] " Jianfeng Tan
2017-04-14  4:24   ` Yuanhan Liu [this message]
2017-04-14  4:35     ` Tan, Jianfeng
2017-04-14  5:37       ` Yuanhan Liu
2017-04-14  5:55         ` Tan, Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170414042423.GI7333@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).