From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] net/virtio-user: fix not working on 32-bit
	system
Date: Fri, 14 Apr 2017 14:20:17 +0800
Message-ID: <20170414062017.GM7333@yliu-dev.sh.intel.com>
References: <1492092776-57008-1-git-send-email-jianfeng.tan@intel.com>
 <20170414053222.GK7333@yliu-dev.sh.intel.com>
 <ED26CBA2FAD1BF48A8719AEF02201E365119F5FB@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E365119F5FB@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 14, 2017 at 05:53:55AM +0000, Tan, Jianfeng wrote:
> > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> > > index f9e3736..f43ea70 100644
> > > --- a/drivers/net/virtio/virtqueue.h
> > > +++ b/drivers/net/virtio/virtqueue.h
> > > @@ -72,7 +72,8 @@ struct rte_mbuf;
> > >   * Return the physical address (or virtual address in case of
> > >   * virtio-user) of mbuf data buffer.
> > >   */
> > > -#define VIRTIO_MBUF_ADDR(mb, vq) (*(uint64_t *)((uintptr_t)(mb) +
> > (vq)->offset))
> > > +#define VIRTIO_MBUF_ADDR(mb, vq) \
> > > +	((uint64_t)((uintptr_t)(*(void **)((uintptr_t)(mb) + (vq)->offset))))
> > 
> > The "void **" cast makes it a bit complex (thus hard to read). I think
> > following should work?
> 
> Yes, uintptr_t can work. I thought void ** is easier to understand, meaning a convert to a pointer which pointing to a pointer.

It's twisted, isn't it? :)

> I usually use uintptr_t only for converter from pointer to integer, not the opposite way.

Yes, that's a typical usage. But the fact of the matter is uintptr_t
represents the word size, which is exactly what needed in this case.

	--yliu
> 
> > 
> >     (uint64_t(*(uintptr_t *)((uintptr_t)(mb) + (vq)->offset)))
> > 
> > Besides, it deserves a comment.
> 
> Will add comment in next version.
> 
> Thanks,
> Jianfeng
> 
> > 
> > 	--yliu
> > 
> > >  #else
> > >  #define VIRTIO_MBUF_ADDR(mb, vq) ((mb)->buf_physaddr)
> > >  #endif
> > > --
> > > 2.7.4