From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: [PATCH] event/sw: fix events mis-identified as needing reorder Date: Fri, 14 Apr 2017 16:18:15 +0100 Message-ID: <20170414151815.12850-1-bruce.richardson@intel.com> Cc: dev@dpdk.org, Bruce Richardson To: harry.van.haaren@intel.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2BCC9378B for ; Fri, 14 Apr 2017 17:18:25 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When taking events from a port, we checked the history list to check if the event needed to be put back in order i.e. originally came from a reordered queue type. The check for reordering involved checking if the reorder buffer entry pointer was null. However, after that pointer was used it was never cleared to null again. This caused problems when we had mixed reordered and atomic or parallel events, as the events from the latter two queue types were misidentified as needing reordering. This let in some cases to crashes, but mostly led to dropping events, and then application lock-up. Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") Signed-off-by: Bruce Richardson --- drivers/event/sw/sw_evdev_scheduler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c index e008b51..a333a6f 100644 --- a/drivers/event/sw/sw_evdev_scheduler.c +++ b/drivers/event/sw/sw_evdev_scheduler.c @@ -448,6 +448,7 @@ __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder) struct reorder_buffer_entry *rob_entry = hist_entry->rob_entry; + hist_entry->rob_entry = NULL; /* Although fragmentation not currently * supported by eventdev API, we support it * here. Open: How do we alert the user that -- 2.9.3