From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments Date: Tue, 18 Apr 2017 15:03:04 +0200 Message-ID: <20170418150304.58d2c4a1@glumotte.dev.6wind.com> References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com> <20170404162807.20157-1-olivier.matz@6wind.com> <20170404162807.20157-7-olivier.matz@6wind.com> <20170406054523.GP18844@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, mb@smartsharesystems.com, andrey.chilikin@intel.com, jblunck@infradead.org, nelio.laranjeiro@6wind.com, arybchenko@solarflare.com, thomas.monjalon@6wind.com, jerin.jacob@caviumnetworks.com To: Yuanhan Liu Return-path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id A1BE72C5 for ; Tue, 18 Apr 2017 15:02:39 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id c55so102053823wrc.3 for ; Tue, 18 Apr 2017 06:02:39 -0700 (PDT) In-Reply-To: <20170406054523.GP18844@yliu-dev.sh.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Yuanhan, On Thu, 6 Apr 2017 13:45:23 +0800, Yuanhan Liu wrote: > Hi Olivier, > > On Tue, Apr 04, 2017 at 06:28:05PM +0200, Olivier Matz wrote: > > Change the size of m->port and m->nb_segs to 16 bits. > > But all the ethdev APIs are still using 8 bits. 16 bits won't really > take effect without updating those APIs. Any plans? > > --yliu Yes, there is some work in ethdev, drivers and in example apps to make the change effective. I think we could define a specific type for a port number, maybe rte_eth_port_num_t. Using this type could be a first step (for 17.08) before switching to 16 bits (17.11?). I'll do the change and send a rfc. Regards, Olivier