From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH v2 0/8] mbuf: structure reorganization Date: Tue, 18 Apr 2017 15:04:48 +0200 Message-ID: <20170418150448.49b9934f@glumotte.dev.6wind.com> References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com> <20170404162807.20157-1-olivier.matz@6wind.com> <2948467.vjfs1XSdfO@xps13> <2ead9890-5759-5c31-1805-588967c7cbf2@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, mb@smartsharesystems.com, andrey.chilikin@intel.com, jblunck@infradead.org, nelio.laranjeiro@6wind.com, arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com To: Ferruh Yigit Return-path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id E76C62FDD for ; Tue, 18 Apr 2017 15:04:23 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id l28so101900209wre.0 for ; Tue, 18 Apr 2017 06:04:23 -0700 (PDT) In-Reply-To: <2ead9890-5759-5c31-1805-588967c7cbf2@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On Fri, 14 Apr 2017 14:10:33 +0100, Ferruh Yigit wrote: > On 4/5/2017 10:37 AM, Thomas Monjalon wrote: > > 2017-04-04 18:27, Olivier Matz: > >> Based on discussions done in [1] and in this thread, this patchset reorganizes > >> the mbuf. > >> > >> The main changes are: > >> - reorder structure to increase vector performance on some non-ia > >> platforms.! > >> - add a 64bits timestamp field in the 1st cache line. This timestamp > >> is not normalized, i.e. no unit or time reference is enforced. A > >> library may be added to do this job in the future. > >> - m->next, m->nb_segs, and m->refcnt are always initialized for mbufs > >> in the pool, avoiding the need of setting m->next (located in the > >> 2nd cache line) in the Rx path for mono-segment packets. > >> - change port and nb_segs to 16 bits > >> - move seqn in the 2nd cache line > > > > Applied, thanks for the long work > > > > <...> > > >> Once this patchset is pushed, the Rx path of drivers could be optimized a bit, > >> by removing writes to m->next, m->nb_segs and m->refcnt. The patch 4/8 gives an > >> idea of what could be done. > > Hi Olivier, > > Some driver patches already received for this update, but not all yet. > > Can you please describe what changes are required in PMDs after this > patch? And what will be effect of doing changes or not? Yes, I will do it. > Later we can circulate this information through the PMD maintainers to > be sure proper updates done. That would be good. Do you know what will be the procedure to inform the PMD maintainers? Is there a specific mailing list? Thanks, Olivier