From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH 3/6] eal: remove log level from internal
	config
Date: Tue, 18 Apr 2017 17:26:19 +0200
Message-ID: <20170418172619.2889e7d2@glumotte.dev.6wind.com>
References: <20170418142225.6308-1-olivier.matz@6wind.com>
 <20170418142225.6308-3-olivier.matz@6wind.com>
 <e3677a93-257d-ba78-10b0-5573ca3a86bd@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, jianfeng.tan@intel.com, thomas@monjalon.net
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id 5D1ACF94
 for <dev@dpdk.org>; Tue, 18 Apr 2017 17:25:52 +0200 (CEST)
Received: by mail-wm0-f53.google.com with SMTP id o81so59198249wmb.1
 for <dev@dpdk.org>; Tue, 18 Apr 2017 08:25:52 -0700 (PDT)
In-Reply-To: <e3677a93-257d-ba78-10b0-5573ca3a86bd@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Tue, 18 Apr 2017 16:00:45 +0100, Ferruh Yigit <ferruh.yigit@intel.com> w=
rote:
> On 4/18/2017 3:22 PM, Olivier Matz wrote:
> > This field is only used in the initialization phase. Remove it since the
> > global log level can also be retrieved using a public API:
> > rte_log_get_global_level().
> >=20
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com> =20
>=20
> <...>
>=20
> > diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/co=
mmon/eal_common_log.c
> > index dd4d30ca7..7d13cc026 100644
> > --- a/lib/librte_eal/common/eal_common_log.c
> > +++ b/lib/librte_eal/common/eal_common_log.c
> > @@ -244,6 +244,12 @@ RTE_INIT(rte_log_init);
> >  static void
> >  rte_log_init(void)
> >  {
> > +#if RTE_LOG_LEVEL >=3D RTE_LOG_DEBUG =20
>=20
> Why ">=3D" (I aware previous one is also like this :), setting global
> config option to RTE_LOG_DEBUG cause a INFO level log...
>=20
> > +	rte_log_set_global_level(RTE_LOG_INFO);
> > +#else
> > +	rte_log_set_global_level(RTE_LOG_LEVEL);
> > +#endif =20
>=20

=46rom what I see, in the previous commit 9b9d7caa8414 ("log: increase default
level to info"), some code was added to prevent to set the default log
level to DEBUG, because it has an impact on performance.
   =20
But since commit 5d8f0baf69ea ("log: do not drop debug logs at compile time=
"),
the logs that impact performance should use RTE_LOG_DP().

I think this can be removed, and changed to:

 rte_log_set_global_level(RTE_LOG_LEVEL);


I did not do it in this patchset because I think it can wait next
version.