From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v2 1/5] ethdev: introduce device removal event
Date: Tue, 25 Apr 2017 11:05:36 +0200
Message-ID: <20170425090536.GS14914@bidouze.vm.6wind.com>
References: <cover.1492517222.git.gaetan.rivet@6wind.com>
 <ad86ce93ead0e79acbe65d08038ec0ec1ddbb01e.1492517222.git.gaetan.rivet@6wind.com>
 <923e5a49-6514-4a28-fb89-81e196ae99c9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Elad Persiko <eladpe@mellanox.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Olivier MATZ <olivier.matz@6wind.com>, Billy McFall <bmcfall@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 058C75911
 for <dev@dpdk.org>; Tue, 25 Apr 2017 11:05:44 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id m123so89688807wma.0
 for <dev@dpdk.org>; Tue, 25 Apr 2017 02:05:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <923e5a49-6514-4a28-fb89-81e196ae99c9@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Fri, Apr 21, 2017 at 03:59:24PM +0100, Ferruh Yigit wrote:
>On 4/18/2017 1:17 PM, Gaetan Rivet wrote:
>> This new API allows reacting to a device removal.
>> A device removal is the sudden disappearance of a device from its
>> bus.
>>
>> PMDs implementing support for this notification guarantee that the removal
>> of the underlying device does not incur a risk to the application.
>>
>> In particular, Rx/Tx bursts and all other functions can still be called
>> (albeit likely returning errors) without triggering a crash, irrespective
>> of an application handling this event.
>>
>> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
>
><...>
>
>> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
>> index b1b9114..cafc6c7 100644
>> --- a/doc/guides/nics/features/default.ini
>> +++ b/doc/guides/nics/features/default.ini
>> @@ -10,6 +10,7 @@
>>  Speed capabilities   =
>>  Link status          =
>>  Link status event    =
>> +Removal event        =
>>  Queue status event   =
>>  Rx interrupt         =
>>  Free Tx mbuf on demand =
>
>This release a few NIC features added, and it is hard to follow them if
>you are particularly looking for these features.
>
>So do you think does it make sense to put those new PMD features into
>release notes to make it more visible?
>

Yes it seems like a good idea to announce this evolution. I will
send the relevant patch for this soon.

>Thanks,
>ferruh

-- 
Gaëtan Rivet
6WIND