From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 07/13] net/avp: fix errors in exported
	headers
Date: Tue, 25 Apr 2017 16:48:33 +0200
Message-ID: <20170425144832.GO3790@6wind.com>
References: <cover.1493048352.git.adrien.mazarguil@6wind.com>
 <cover.1493108423.git.adrien.mazarguil@6wind.com>
 <046efd0fda00bfb5253586319fb9cfbf904a8f0a.1493108423.git.adrien.mazarguil@6wind.com>
 <70A7408C6E1BFB41B192A929744D85239690F2B7@ALA-MBC.corp.ad.wrs.com>
 <20170425124959.GJ3790@6wind.com>
 <70A7408C6E1BFB41B192A929744D85239690F322@ALA-MBC.corp.ad.wrs.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Peters, Matt" <Matt.Peters@windriver.com>
To: "Legacy, Allain" <Allain.Legacy@windriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 1267E2B9B
 for <dev@dpdk.org>; Tue, 25 Apr 2017 16:48:40 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id m123so98503054wma.0
 for <dev@dpdk.org>; Tue, 25 Apr 2017 07:48:40 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <70A7408C6E1BFB41B192A929744D85239690F322@ALA-MBC.corp.ad.wrs.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 25, 2017 at 01:00:46PM +0000, Legacy, Allain wrote:
> > -----Original Message-----
> > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> > Sent: Tuesday, April 25, 2017 8:50 AM
> <...>
> > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__.
> > 
> > Missed that one, however I suggest either:
> > 
> >  #ifndef __KERNEL__ around RTE_STD_C11
> > 
> > or using __extension__ directly. Which do you prefer?
> 
> I would prefer if it was done as it is done in rte_kni_common.h to provide consistency with other similar files.  Like this:
> 
> 	#ifdef __KERNEL__
> 	#include <linux/if.h>
> 	#define RTE_STD_C11
> 	#else
> 	#include <rte_common.h>
> 	#endif
> 
> ...but if you disagree then I prefer the #ifndef __KERNEL__ option.

You're right in fact, I did not remember that was the method used for
KNI. Let's keep your suggestion.

> > 
> > By the way, is the kernel module that depends on rte_avp_common.h
> > available somewhere to validate compilation against it?
> 
> There is an older version of the module available on github, but it has not been updated since the AVP driver has been included in the DPDK.   Since the AVP directory and files were significantly changed in order to meet the requirements of the DPDK it won't be much use to you.    Until we can update it please make sure both Matt Peters and I are CC'd on the patch requests and we'll confirm compilation as quickly as possible.
> 
> 
> > > Would you mind changing the brackets (<>) to quotes ("") since this is a
> > local include file?
> > >
> > > 	#include "rte_avp_common.h"
> > 
> > I will update it.
> 
> 
> Thank you.

Can I add your acked-by line directly assuming all the above is done as
described?

-- 
Adrien Mazarguil
6WIND