From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2] vhost: workaround MQ fails to startup
Date: Fri, 28 Apr 2017 12:29:17 +0800
Message-ID: <20170428042917.GN11512@yliu-dev.sh.intel.com>
References: <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com>
 <1493286083-53632-1-git-send-email-zhiyong.yang@intel.com>
 <9dd4408d-0d01-5e44-06e9-8dca15bf18f8@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Zhiyong Yang <zhiyong.yang@intel.com>, dev@dpdk.org,
 ciara.loftus@intel.com, stable@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <9dd4408d-0d01-5e44-06e9-8dca15bf18f8@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote:
> 
> 
> On 04/27/2017 11:41 AM, Zhiyong Yang wrote:
> >   vhost since dpdk17.02 + qemu2.7 and above will cause failures of
> >new connection when negotiating to set MQ. (one queue pair works
> >well).
> >    Because there exist some bugs in qemu code when introducing
> >VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the vhost
> >message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed
> >doesn't send the messge (The message needs to be sent only once)but
> >still will be waiting for dpdk's reply ack, then, qemu is always
> >freezing. DPDK code indeed works in the right way.
> >    The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled
> >by default at the dpdk side in order to avoid the feature support of
> >DPDK + qemu at the same time. if doing like that, MQ can works well.
> >
> >Cc: stable@dpdk.org
> >
> >Reported-by: Ciara Loftus <ciara.loftus@intel.com>
> >Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> >Tested-by: Ciara Loftus <ciara.loftus@intel.com>
> >---
> >
> >changes in V2
> >1. modify "workaround" instead of "fix" in the title.
> >2. add a simple comment suggested by yuanhan
> >
> >  lib/librte_vhost/vhost_user.h | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu