From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] lib/librte_cmdline: fix CLI parsing issue
Date: Fri, 28 Apr 2017 11:13:25 +0200
Message-ID: <20170428111325.7f0d2ab2@platinum>
References: <1493089885-94889-1-git-send-email-wenzhuo.lu@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B59DB03@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "stable@dpdk.org" <stable@dpdk.org>, "Glynn, Michael J"
 <michael.j.glynn@intel.com>, "Liu, Yu Y" <yu.y.liu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id AEE609E3
 for <dev@dpdk.org>; Fri, 28 Apr 2017 11:13:28 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id l50so30121221wrc.3
 for <dev@dpdk.org>; Fri, 28 Apr 2017 02:13:28 -0700 (PDT)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59DB03@shsmsx102.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Wenzhuo,

On Fri, 28 Apr 2017 08:38:21 +0000, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> Hi Oilvier,
> As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks.
> 
> 
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Tuesday, April 25, 2017 11:11 AM
> > To: dev@dpdk.org
> > Cc: olivier.matz@6wind.com; Lu, Wenzhuo; stable@dpdk.org
> > Subject: [PATCH] lib/librte_cmdline: fix CLI parsing issue
> > 
> > When parsing a CLI, all the CLI instances are checked one by one. Even if an
> > instance already matches the CLI, the parsing will not stop for ambiguous
> > check.
> > The problem is that the following check may change the parsing result of the
> > previous one even if the following instance doesn't match.
> > 
> > Use a temporary validate for the parsing result when trying to match an
> > instance and only store the result when it matches, so the previous result
> > has no chance to be changed.
> > 
> > Fixes: af75078fece3 ("first public release")
> > CC: stable@dpdk.org
> > 
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Sorry for the delay,

Acked-by: Olivier Matz <olivier.matz@6wind.com>