From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v7 1/3] ethdev: fix adding invalid MAC addr
Date: Sun, 7 May 2017 12:39:10 +0800
Message-ID: <20170507043910.GF3005@yliu-dev.sh.intel.com>
References: <1493729065-17090-1-git-send-email-wei.dai@intel.com>
 <1493944802-52943-1-git-send-email-wei.dai@intel.com>
 <1493944802-52943-2-git-send-email-wei.dai@intel.com>
 <7497469.TuTdfvjb2m@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Wei Dai <wei.dai@intel.com>, dev@dpdk.org, wenzhuo.lu@intel.com,
 harish.patil@cavium.com, rasesh.mody@cavium.com,
 stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com,
 helin.zhang@intel.com, konstantin.ananyev@intel.com,
 jingjing.wu@intel.com, jing.d.chen@intel.com,
 adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
 bruce.richardson@intel.com, maxime.coquelin@redhat.com,
 shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com,
 john.miller@atomicrules.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 76A1E282
 for <dev@dpdk.org>; Sun,  7 May 2017 06:43:05 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <7497469.TuTdfvjb2m@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 05, 2017 at 04:21:53PM +0200, Thomas Monjalon wrote:
> 05/05/2017 02:40, Wei Dai:
> > Some customers find adding MAC addr to VF sometimes can fail,
> > but it is still stored in dev->data->mac_addrs[ ]. So this
> > can lead to some errors that assumes the non-zero entry in
> > dev->data->mac_addrs[ ] is valid.
> > Following acknowledgements are from specific NIC PMD
> > maintainer for their managing part.
> > 
> > This patch changes the ethdev API, it should not be
> > backported to a stable/LTS release so far.
> 
> It changes only the internal function pointer used by drivers,
> not the API.

Oh, right. I was thinking the eth API rte_eth_dev_mac_addr also has to
be changed. It turned out that it's already been designed with returning
"int".

Sorry for the noise.

	--yliu