From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiwei Bie Subject: Re: [PATCH 1/2] eal/bsd: fix ioport write operation Date: Mon, 8 May 2017 17:07:36 +0800 Message-ID: <20170508090736.GA11935@debian> References: <20170507133334.16219-1-tiwei.bie@intel.com> <20170507133334.16219-2-tiwei.bie@intel.com> <20170508085501.GB47408@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: dev@dpdk.org, stable@dpdk.org To: Bruce Richardson Return-path: Content-Disposition: inline In-Reply-To: <20170508085501.GB47408@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 08, 2017 at 09:55:01AM +0100, Bruce Richardson wrote: > On Sun, May 07, 2017 at 01:33:33PM +0000, Tiwei Bie wrote: > > The first param of out*() on FreeBSD is port, and the second one is > > data. But they are reversed in DPDK. This patch fixes it. > > > > Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") Cc: > > stable@dpdk.org > > > > Signed-off-by: Tiwei Bie --- > How was this bug discovered so that we can verify that it is fixed?. Is > this in use by virtio or was it just discovered via code inspection? > The virtio PMD in legacy mode doesn't work FreeBSD, and I tried to fix this issue. And then I found this bug. Best regards, Tiwei Bie