From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] net/null: do not touch mbuf next or nb segs on Rx Date: Tue, 9 May 2017 09:24:37 +0200 Message-ID: <20170509092437.652bac1c@platinum> References: <20170504154358.40122-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Tetsuya Mukawa , dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 9924B2C3F for ; Tue, 9 May 2017 09:24:39 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id u65so601331wmu.1 for ; Tue, 09 May 2017 00:24:39 -0700 (PDT) In-Reply-To: <20170504154358.40122-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 4 May 2017 16:43:58 +0100, Ferruh Yigit wrote: > mbuf next and nb_segs fields already have the default values when get > from mempool, no need to update them in PMD. > > See: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > > Signed-off-by: Ferruh Yigit > --- > Cc: Olivier Matz > --- > drivers/net/null/rte_eth_null.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index abf3ec7..2c94339 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -139,8 +139,6 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) > packet_size); > bufs[i]->data_len = (uint16_t)packet_size; > bufs[i]->pkt_len = packet_size; > - bufs[i]->nb_segs = 1; > - bufs[i]->next = NULL; > bufs[i]->port = h->internals->port_id; > } > Reviewed-by: Olivier Matz