From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v2] mbuf: fix bulk allocation when debug
	enabled
Date: Wed, 10 May 2017 16:42:35 +0200
Message-ID: <20170510164235.62fcb469@platinum>
References: <1802735.EECn92tGJO@polaris>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, thomas@monjalon.net
To: Gregory Etelson <gregory@weka.io>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 59003234
 for <dev@dpdk.org>; Wed, 10 May 2017 16:42:38 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id l50so46703816wrc.3
 for <dev@dpdk.org>; Wed, 10 May 2017 07:42:38 -0700 (PDT)
In-Reply-To: <1802735.EECn92tGJO@polaris>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On Sat, 06 May 2017 10:26:49 +0300, Gregory Etelson <gregory@weka.io> wrote:
> The debug assertions when allocating a raw mbuf are not correct since
> commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"),
> which triggers a panic when using this function in debug mode
> 

Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")

> Signed-off-by: Gregory Etelson <gregory@weka.io>
> ---
>  lib/librte_mbuf/rte_mbuf.h | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 9097f18..05b8300 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -788,6 +788,13 @@ rte_mbuf_refcnt_set(struct rte_mbuf *m, uint16_t new_value)
>  void
>  rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header);
>  
> +#define MBUF_RAW_ALLOC_CHECK(m_) do {				\
> +	RTE_ASSERT(rte_mbuf_refcnt_read(m_) == 1);		\
> +	RTE_ASSERT(m_->next == NULL);				\
> +	RTE_ASSERT(m_->nb_segs == 1);				\
> +	__rte_mbuf_sanity_check(m_, 0);				\
> +} while (0)
> +

Few nits:
- maybe 'm_' could be 'm'
- some parenthesis could be added for safety

Thomas, I know you're in hurry for 17.05, I think this fix should
go in. If you want, I can send a v3 with this small changes if you
need it now.

Regards,
Olivier