From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ashwin Sekhar T K Subject: [PATCH v3 1/6] eal: pause while busy-waiting for slave Date: Thu, 11 May 2017 22:45:42 -0700 Message-ID: <20170512054547.753-2-ashwin.sekhar@caviumnetworks.com> References: <20170510101643.30556-1-ashwin.sekhar@caviumnetworks.com> <20170512054547.753-1-ashwin.sekhar@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain Cc: dev@dpdk.org, Ashwin Sekhar T K To: jerin.jacob@caviumnetworks.com, thomas@monjalon.net, maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com, jianbo.liu@linaro.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0043.outbound.protection.outlook.com [104.47.41.43]) by dpdk.org (Postfix) with ESMTP id A256D5920 for ; Fri, 12 May 2017 07:46:03 +0200 (CEST) In-Reply-To: <20170512054547.753-1-ashwin.sekhar@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Instead of simply busy-waiting for slave in rte_eal_wait_lcore() do rte_pause(). This will give power savings. This also fixes warning -Wempty-body seen with armv8a clang compilation. Signed-off-by: Ashwin Sekhar T K Suggested-by: Jerin Jacob --- lib/librte_eal/common/eal_common_launch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_launch.c b/lib/librte_eal/common/eal_common_launch.c index 229c3a034..184846606 100644 --- a/lib/librte_eal/common/eal_common_launch.c +++ b/lib/librte_eal/common/eal_common_launch.c @@ -54,7 +54,8 @@ rte_eal_wait_lcore(unsigned slave_id) return 0; while (lcore_config[slave_id].state != WAIT && - lcore_config[slave_id].state != FINISHED); + lcore_config[slave_id].state != FINISHED) + rte_pause(); rte_rmb(); -- 2.12.2