From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] eventdev: clarify atomic and ordered queue config Date: Mon, 15 May 2017 09:14:18 +0530 Message-ID: <20170515034416.GA21183@jerin> References: <1494617137-8619-1-git-send-email-gage.eads@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.org To: Gage Eads Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0063.outbound.protection.outlook.com [104.47.36.63]) by dpdk.org (Postfix) with ESMTP id 3E59529CB for ; Mon, 15 May 2017 05:44:43 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1494617137-8619-1-git-send-email-gage.eads@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Fri, 12 May 2017 14:25:37 -0500 > From: Gage Eads > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.org > Subject: [dpdk-dev] [PATCH] eventdev: clarify atomic and ordered queue > config > X-Mailer: git-send-email 2.7.4 > > The nb_atomic_flows and nb_atomic_order_sequences fields are only inspected > if the queue is configured for atomic or ordered scheduling, respectively. > This commit updates the documentation to reflect that. > > Signed-off-by: Gage Eads > --- > lib/librte_eventdev/rte_eventdev.h | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index 20e7293..32ffcd1 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -521,9 +521,11 @@ rte_event_dev_configure(uint8_t dev_id, > struct rte_event_queue_conf { > uint32_t nb_atomic_flows; > /**< The maximum number of active flows this queue can track at any > - * given time. The value must be in the range of > - * [1 - nb_event_queue_flows)] which previously provided in > - * rte_event_dev_info_get(). > + * given time. If the queue is configured for atomic scheduling (by > + * applying the RTE_EVENT_QUEUE_CFG_ALL_TYPES or > + * RTE_EVENT_QUEUE_CFG_ATOMIC_ONLY flags to event_queue_cfg), then the > + * value must be in the range of [1 - nb_event_queue_flows)], which was > + * previously provided in rte_event_dev_configure(). > */ > uint32_t nb_atomic_order_sequences; > /**< The maximum number of outstanding events waiting to be > @@ -533,8 +535,11 @@ struct rte_event_queue_conf { > * scheduler cannot schedule the events from this queue and invalid > * event will be returned from dequeue until one or more entries are > * freed up/released. > - * The value must be in the range of [1 - nb_event_queue_flows)] > - * which previously supplied to rte_event_dev_configure(). > + * If the queue is configured for ordered scheduling (by applying the > + * RTE_EVENT_QUEUE_CFG_ALL_TYPES or RTE_EVENT_QUEUE_CFG_ORDERED_ONLY > + * flags to event_queue_cfg), then the value must be in the range of [1 > + * - nb_event_queue_flows)], which was previously supplied to At this line, HTML document rendering is not showing up correctly. Please check the generated HTML output with "make doc-api-html" Other than that, content looks OK. > + * rte_event_dev_configure(). > */ > uint32_t event_queue_cfg; /**< Queue cfg flags(EVENT_QUEUE_CFG_) */ > uint8_t priority; > -- > 2.7.4 >