From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pascal Mazon <pascal.mazon@6wind.com>
Subject: Re: [PATCH v2] drivers/net: document missing speed
 capabilities feature
Date: Mon, 15 May 2017 14:17:07 +0200
Message-ID: <20170515141707.3021bd9b@paques.dev.6wind.com>
References: <20170510131053.75843-1-ferruh.yigit@intel.com>
 <20170515105946.88233-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Shepard Siegel <shepard.siegel@atomicrules.com>, Ed Czeck
 <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, John
 McNamara <john.mcnamara@intel.com>, Harish Patil <harish.patil@cavium.com>,
 Rasesh Mody <rasesh.mody@cavium.com>, Rahul Lakkireddy
 <rahul.lakkireddy@chelsio.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>, Guy
 Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>, Jing
 Chen <jing.d.chen@intel.com>, Helin Zhang <helin.zhang@intel.com>, Jingjing
 Wu <jingjing.wu@intel.com>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>, Adrien Mazarguil
 <adrien.mazarguil@6wind.com>, Nelio Laranjeiro
 <nelio.laranjeiro@6wind.com>, Matej Vido <vido@cesnet.cz>, Yuanhan Liu
 <yuanhan.liu@linux.intel.com>, Ma
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com
 [209.85.220.171]) by dpdk.org (Postfix) with ESMTP id CD0D5234
 for <dev@dpdk.org>; Mon, 15 May 2017 14:17:16 +0200 (CEST)
Received: by mail-qk0-f171.google.com with SMTP id k74so92837118qke.1
 for <dev@dpdk.org>; Mon, 15 May 2017 05:17:16 -0700 (PDT)
In-Reply-To: <20170515105946.88233-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

In the case of tap PMD, I would say it's rather partially supported (P).

Best regards,

Pascal

On Mon, 15 May 2017 11:59:46 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> 
> Please fix partially support to fully supported speed capabilities.
> 
> Please check other features of PMD and document missing ones in features
> file.
> 
> Thanks.
> 
> v2:
> * Mark PMDs that return speed capabilities without checking real
> hardware capabilities to Partially supported "P".
> * Mark PMDs return fake speed capabilities to "P", like virtio and
> vmxnet3.
> ---
>  doc/guides/nics/features/ark.ini          | 1 +
>  doc/guides/nics/features/bnx2x.ini        | 1 +
>  doc/guides/nics/features/bnx2x_vf.ini     | 1 +
>  doc/guides/nics/features/cxgbe.ini        | 1 +
>  doc/guides/nics/features/dpaa2.ini        | 1 +
>  doc/guides/nics/features/e1000.ini        | 1 +
>  doc/guides/nics/features/ena.ini          | 1 +
>  doc/guides/nics/features/fm10k.ini        | 1 +
>  doc/guides/nics/features/fm10k_vec.ini    | 1 +
>  doc/guides/nics/features/fm10k_vf.ini     | 1 +
>  doc/guides/nics/features/fm10k_vf_vec.ini | 1 +
>  doc/guides/nics/features/i40e.ini         | 1 +
>  doc/guides/nics/features/i40e_vec.ini     | 1 +
>  doc/guides/nics/features/igb.ini          | 1 +
>  doc/guides/nics/features/ixgbe.ini        | 1 +
>  doc/guides/nics/features/ixgbe_vec.ini    | 1 +
>  doc/guides/nics/features/mlx4.ini         | 1 +
>  doc/guides/nics/features/szedata2.ini     | 1 +
>  doc/guides/nics/features/tap.ini          | 2 +-
>  doc/guides/nics/features/virtio.ini       | 1 +
>  doc/guides/nics/features/virtio_vec.ini   | 1 +
>  doc/guides/nics/features/vmxnet3.ini      | 1 +
>  22 files changed, 22 insertions(+), 1 deletion(-)

  [...]

> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini
> index 3efae75..d410409 100644
> --- a/doc/guides/nics/features/tap.ini
> +++ b/doc/guides/nics/features/tap.ini
> @@ -4,6 +4,7 @@
>  ; Refer to default.ini for the full list of available PMD features.
>  ;
>  [Features]
> +Speed capabilities   = Y
>  Link status          = Y
>  Link status event    = Y
>  Jumbo frame          = Y
> @@ -13,7 +14,6 @@ Basic stats          = Y
>  Flow API             = Y
>  MTU update           = Y
>  Multicast MAC filter = Y
> -Speed capabilities   = Y
>  Unicast MAC filter   = Y
>  Packet type parsing  = Y
>  Flow control         = Y

  [...]