From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: Guidelines for stats_get ierrors in a media driver
Date: Tue, 16 May 2017 15:41:36 -0700
Message-ID: <20170516154136.7e5c8baf@xeon-e3>
References: <1494969873552.80827@Brocade.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Tom Hall <thall@Brocade.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f52.google.com (mail-pg0-f52.google.com [74.125.83.52])
 by dpdk.org (Postfix) with ESMTP id 9DEFE20F
 for <dev@dpdk.org>; Wed, 17 May 2017 00:41:45 +0200 (CEST)
Received: by mail-pg0-f52.google.com with SMTP id x64so63547636pgd.3
 for <dev@dpdk.org>; Tue, 16 May 2017 15:41:44 -0700 (PDT)
In-Reply-To: <1494969873552.80827@Brocade.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 16 May 2017 21:25:37 +0000
Tom Hall <thall@Brocade.com> wrote:

> I'm trying to make sense of the stats_get ierrors value. It doesn't appear that there is any consistency between any of the net drivers for what this value truly represents. For example, the ixgbe driver calculates the value as
> 
> 
> stats->ierrors  = hw_stats->crcerrs +
>                           hw_stats->mspdc +
>                           hw_stats->rlec +
>                           hw_stats->ruc +
>                           hw_stats->roc +
>                           hw_stats->illerrc +
>                           hw_stats->errbc +
>                           hw_stats->rfc +
>                           hw_stats->fccrc +
>                           hw_stats->fclast;
> 
> While the vmxnet3 driver does the following
> 
> RTE_BUILD_BUG_ON(RTE_ETHDEV_QUEUE_STAT_CNTRS < VMXNET3_MAX_RX_QUEUES); for (i = 0; i < hw->num_rx_queues; i++) { struct UPT1_RxStats *rxStats = &hw->rqd_start[i].stats; stats->q_ipackets[i] = rxStats->ucastPktsRxOK + rxStats->mcastPktsRxOK + rxStats->bcastPktsRxOK; stats->q_ibytes[i] = rxStats->ucastBytesRxOK + rxStats->mcastBytesRxOK + rxStats->bcastBytesRxOK; stats->ipackets += stats->q_ipackets[i]; stats->ibytes += stats->q_ibytes[i]; stats->q_errors[i] = rxStats->pktsRxError; stats->ierrors += rxStats->pktsRxError; stats->rx_nombuf += rxStats->pktsRxOutOfBuf; }
> 
> The bnx2x driver sets the value in this way
> 
> stats->ierrors =
>                 HILO_U64(sc->eth_stats.error_bytes_received_hi,
>                                 sc->eth_stats.error_bytes_received_lo);
> 
> Can someone address this inconsistancY? What should stats->ierrors represent?
> 
> Tom Hall
> 
> Brocade Communications

IMHO the DPDK driver should give the same value for ierrors that shows up for the analogous
driver in Linux kernel. I.e DPDK ierrors == Linux rx_errors (== ifi_ierrors BSD).

What you see is different drivers combining different internal error counters to produce
the same effective result.

If you want to drill down into each device type. then there are xstats for that.