From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC][PATCH] vfio: allow to map other memory regions
Date: Wed, 17 May 2017 10:20:23 -0700
Message-ID: <20170517102023.3c78590e@xeon-e3>
References: <1495032287-216322-1-git-send-email-pawelx.wodkowski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 11EE32C2F
 for <dev@dpdk.org>; Wed, 17 May 2017 19:20:33 +0200 (CEST)
Received: by mail-pf0-f182.google.com with SMTP id 9so10584055pfj.1
 for <dev@dpdk.org>; Wed, 17 May 2017 10:20:33 -0700 (PDT)
In-Reply-To: <1495032287-216322-1-git-send-email-pawelx.wodkowski@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 17 May 2017 16:44:46 +0200
Pawel Wodkowski <pawelx.wodkowski@intel.com> wrote:

>  /* IOMMU types we support */
>  static const struct vfio_iommu_type iommu_types[] = {
>  	/* x86 IOMMU, otherwise known as type 1 */
> -	{ RTE_VFIO_TYPE1, "Type 1", &vfio_type1_dma_map},
> +	{ RTE_VFIO_TYPE1, "Type 1", &vfio_type1_dma_map, &vfio_type1_dma_mem_map},
>  	/* ppc64 IOMMU, otherwise known as spapr */
> -	{ RTE_VFIO_SPAPR, "sPAPR", &vfio_spapr_dma_map},
> +	{ RTE_VFIO_SPAPR, "sPAPR", &vfio_spapr_dma_map, NULL},
>  	/* IOMMU-less mode */
> -	{ RTE_VFIO_NOIOMMU, "No-IOMMU", &vfio_noiommu_dma_map},
> +	{ RTE_VFIO_NOIOMMU, "No-IOMMU", &vfio_noiommu_dma_map, &vfio_noiommu_dma_mem_map},
>  };

For complex tables like this why not use C99 style initializer.