From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] vhost: support rx_queue_count
Date: Wed, 24 May 2017 16:14:19 +0800
Message-ID: <20170524081419.GU2276@yliu-dev>
References: <1495483268-60184-1-git-send-email-zhihong.wang@intel.com>
 <20170523115335.gtykyluswrsjuls3@dhcp-192-218.str.redhat.com>
 <8F6C2BD409508844A0EFC19955BE09415127D9EE@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jens Freimann <jfreiman@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Wang, Zhihong" <zhihong.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3771D1F5
 for <dev@dpdk.org>; Wed, 24 May 2017 10:14:14 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <8F6C2BD409508844A0EFC19955BE09415127D9EE@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote:
> 
> 
> > -----Original Message-----
> > From: Jens Freimann [mailto:jfreiman@redhat.com]
> > Sent: Tuesday, May 23, 2017 7:54 PM
> > To: Wang, Zhihong <zhihong.wang@intel.com>
> > Cc: dev@dpdk.org; yuanhan.liu@linux.intel.com
> > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count
> > 
> > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote:
> > > This patch implements the ops rx_queue_count for vhost PMD by adding
> > > a helper function rte_vhost_rx_queue_count in vhost lib.
> > >
> > > The ops ops rx_queue_count gets vhost RX queue avail count and helps
> > 
> > s/ops ops/ops/ ?
> 
> Thanks a lot!

Seems you overlooked other comments, such as:

> > > +	vq = dev->virtqueue[qid];
> > 
> > check for vq == NULL?
> > 
> > regards,
> > Jens

Besides, Jens, I'm not a big fan of "dev == NULL" over "!dev". I accept
both :)

	--yliu