From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH] ethdev: add isolated mode to flow API
Date: Wed, 24 May 2017 15:53:33 +0200
Message-ID: <20170524135333.GJ31330@autoinstall.dev.6wind.com>
References: <4a269110b5623a0a72e4fe9d2636414de5921473.1492609343.git.adrien.mazarguil@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 John McNamara <john.mcnamara@intel.com>,
 "O'Driscoll, Tim" <tim.odriscoll@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, John Daley <johndale@cisco.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Helin Zhang <helin.zhang@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Pascal Mazon <pascal.mazon@6wind.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 715537CCC
 for <dev@dpdk.org>; Wed, 24 May 2017 15:53:40 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id d127so69201823wmf.0
 for <dev@dpdk.org>; Wed, 24 May 2017 06:53:40 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4a269110b5623a0a72e4fe9d2636414de5921473.1492609343.git.adrien.mazarguil@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Apr 19, 2017 at 03:45:31PM +0200, Adrien Mazarguil wrote:
> Isolated mode can be requested by applications on individual ports to avoid
> ingress traffic outside of the flow rules they define.
> 
> Besides making ingress more deterministic, it allows PMDs to safely reuse
> resources otherwise assigned to handle the remaining traffic, such as
> global RSS configuration settings, VLAN filters, MAC address entries,
> legacy filter API rules and so on in order to expand the set of possible
> flow rule types.
> 
> To minimize code complexity, PMDs implementing this mode may provide
> partial (or even no) support for flow rules when not enabled (e.g. no
> priorities, no RSS action). Applications written to use the flow API are
> therefore encouraged to enable it.
> 
> Once effective, leaving isolated mode may not be possible depending on PMD
> implementation.
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: John McNamara <john.mcnamara@intel.com>
> Cc: "O'Driscoll, Tim" <tim.odriscoll@intel.com>
> Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
> Cc: John Daley <johndale@cisco.com>
> Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Cc: Helin Zhang <helin.zhang@intel.com>
> Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: Pascal Mazon <pascal.mazon@6wind.com>


Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

By the way I have implemented it for mlx5 driver [1], your patch needs
to be updated on master-net, is does not apply like this.

Thanks,

[1] http://dpdk.org/dev/patchwork/patch/24487/

-- 
Nélio Laranjeiro
6WIND