From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] ethdev: add function to adjust number of descriptors Date: Thu, 25 May 2017 10:40:33 -0700 Message-ID: <20170525104033.43a6e02f@xeon-e3> References: <1488459935-13273-2-git-send-email-arybchenko@solarflare.com> <1495727874-10892-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , Sergio Gonzalez Monroy , Remy Horton , Jianfeng Tan , Declan Doherty , Ferruh Yigit , Yuanhan Liu , Maxime Coquelin , Konstantin Ananyev , Bruce Richardson , Reshma Pattan , Cristian Dumitrescu , Byron Marohn , Pablo de Lara Guarch , Pawel Wodkowski , Tomasz Kantecki , John McNamara , Daniel Mrzyglod , Roman Zhukov To: Andrew Rybchenko Return-path: Received: from mail-pf0-f175.google.com (mail-pf0-f175.google.com [209.85.192.175]) by dpdk.org (Postfix) with ESMTP id C3214999C for ; Thu, 25 May 2017 19:40:41 +0200 (CEST) Received: by mail-pf0-f175.google.com with SMTP id e193so173672318pfh.0 for ; Thu, 25 May 2017 10:40:41 -0700 (PDT) In-Reply-To: <1495727874-10892-1-git-send-email-arybchenko@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 25 May 2017 16:57:53 +0100 Andrew Rybchenko wrote: > From: Roman Zhukov > > Check that numbers of Rx and Tx descriptors satisfy descriptors limits > from the Ethernet device information, otherwise adjust them to boundaries. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko Seems like new added complexity. Why not just allow devices to take the request as a hint and truncate or pad as needed. IMHO to be successful DPDK must have as simple as possible API for application. Good enough and as little more as possible. But other people seem to think that having the richest and most complex possible API is a good thing.