From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Subject: Re: i40e igb_uio: reset pci on process exit
Date: Fri, 26 May 2017 11:35:11 +0530
Message-ID: <20170526060509.GA5157@localhost.localdomain>
References: <106841857.Z7q1jSDIte@polaris> <20170525114242.3c6ac1b7@xeon-e3>
 <2080347.1TTqQevoe3@polaris>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
To: Gregory Etelson <gregory@weka.io>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0070.outbound.protection.outlook.com [104.47.41.70])
 by dpdk.org (Postfix) with ESMTP id 8386699DA
 for <dev@dpdk.org>; Fri, 26 May 2017 08:05:29 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <2080347.1TTqQevoe3@polaris>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote:

Hi Gregory,

The patch is useful for LiquidIO PMD as we can avoid VF FLR request to
PF. One comment inline..

[..]
> > >  
> > > +static int
> > > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > > +{
> > > +       int ret;
> > > +       struct rte_uio_pci_dev *udev = info->priv;
> > > +       struct pci_dev *dev = udev->pdev;
> > > +       ret = __pci_reset_function(dev);

s/__pci_reset_function/pci_reset_function

> > > +       dev_info(&dev->dev, "pci_reset_function %s \n",
> > > +                 ret == 0 ? "succeded" : "failed");
> > > +       return 0;
> > > +}
[..]

Thanks,
Shijith