From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2] net/mlx4: support user space rxq
	interrupt event
Date: Tue, 30 May 2017 15:29:32 +0200
Message-ID: <20170530132932.GB1758@6wind.com>
References: <1495984291-66861-1-git-send-email-motih@mellanox.com>
 <1495987898-70002-1-git-send-email-motih@mellanox.com>
 <1495987898-70002-2-git-send-email-motih@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, vasilyf@mellanox.com
To: Moti Haimovsky <motih@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 6A7F023B
 for <dev@dpdk.org>; Tue, 30 May 2017 15:29:39 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id m7so27805916wmg.0
 for <dev@dpdk.org>; Tue, 30 May 2017 06:29:39 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1495987898-70002-2-git-send-email-motih@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, May 28, 2017 at 07:11:38PM +0300, Moti Haimovsky wrote:
> Implement rxq interrupt callbacks
> 
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>

Hi Moti,

While this patch is almost identical to its mlx5 counterpart, I have one
minor nit (see below). Besides that:

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

> ---
>  doc/guides/nics/features/mlx4.ini      |   1 +
>  doc/guides/rel_notes/release_17_08.rst |   5 +
>  drivers/net/mlx4/mlx4.c                | 218 ++++++++++++++++++++++++++++++++-
>  drivers/net/mlx4/mlx4.h                |   1 +
>  4 files changed, 219 insertions(+), 6 deletions(-)
[...]
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index ec4419a..95ab325 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -75,6 +75,7 @@
>  #include <rte_memory.h>
>  #include <rte_flow.h>
>  #include <rte_kvargs.h>
> +#include <rte_interrupts.h>
>  
>  /* Generated configuration header. */
>  #include "mlx4_autoconf.h"
> @@ -127,6 +128,30 @@ struct mlx4_conf {
>  	NULL,
>  };
>  
> +static void
> +mlx4_dev_link_status_handler(void *);
> +
> +static void
> +mlx4_dev_interrupt_handler(void *);
> +

I understand the need for a clean up, however these definitions are not
related to this patch.

[...]
>  
> -static void
> -mlx4_dev_link_status_handler(void *);
> -static void
> -mlx4_dev_interrupt_handler(void *);
> -

Please leave them here.

-- 
Adrien Mazarguil
6WIND