From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC PATCH] igb_uio: issue FLR during open and release of device file Date: Wed, 31 May 2017 08:29:08 -0700 Message-ID: <20170531082908.5f649efc@xeon-e3> References: <1748341.rbpcFmWp0q@polaris> <1496228966-18573-1-git-send-email-shijith.thotton@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Gregory Etelson , dev@dpdk.org, Ferruh Yigit , Qi Zhang , Wenzhuo Lu , Thomas Monjalon To: Shijith Thotton Return-path: Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50]) by dpdk.org (Postfix) with ESMTP id 7531D7CDA for ; Wed, 31 May 2017 17:29:11 +0200 (CEST) Received: by mail-pg0-f50.google.com with SMTP id u13so37619pgb.0 for ; Wed, 31 May 2017 08:29:11 -0700 (PDT) In-Reply-To: <1496228966-18573-1-git-send-email-shijith.thotton@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 31 May 2017 16:39:26 +0530 Shijith Thotton wrote: > + /* reset the pci device */ > + pci_reset_function(dev); It is not considered best practice to comment the obvious. This comment borders on being the classic /* add one to i */